Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): add option to skip missing composite editor #232

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

ghiscoding
Copy link
Owner

  • in some cases user might want to skip the fact that the composite editor might be missing from the form value but still wish to apply a value, we can now do that with a skip argument

- in some cases user might want to skip the fact that the composite editor might be missing from the form value but still wish to apply a value, we can now do that with a skip argument
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #232 (e8798b1) into master (fc80301) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #232   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        11878     11878           
  Branches      4073      4074    +1     
=========================================
  Hits         11878     11878           
Impacted Files Coverage Δ
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc80301...e8798b1. Read the comment docs.

@ghiscoding ghiscoding merged commit 925dba8 into master Jan 8, 2021
@ghiscoding ghiscoding deleted the bugfix/composite-editor-not-found-skip-error branch January 8, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant